Make text_factory for PY2

[item4]

Read the #243 for more info.

fix #243

[singingwolfboy]

This looks like a great solution, but it's hard to understand. I know that if I took a look a this code without understanding the problem, I wouldn't understand what these lines are supposed to achieve. Can you add a comment explaining what's going on here, and maybe add an automated test as well?

[item4]

@singingwolfboy I made test. but I want to check by @mitsuhiko what he want to support multibyte fully. Old test case do not allow multibyte directory name.

[item4]

I will add comments and tests case asap.

---

보낸 사람: David Baumgold notifications@github.com
보낸 날짜: 2016년 10월 21일 금요일 오후 10:19:58
받는 사람: lektor/lektor
참조: item4; Author
제목: Re: [lektor/lektor] Make text_factory for PY2 (#299)

This looks like a great solution, but it's hard to understand. I know that if I took a look a this code without understanding the problem, I wouldn't understand what these lines are supposed to achieve. Can you add a comment explaining what's going on here, and maybe add an automated test as well?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/299#issuecomment-255374550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAiLUP9QcC_6ZWld01xUJjKELZEtCyqSks5q2Lv-gaJpZM4KVyuJ.

[singingwolfboy]

Thanks! Looks like you created a file called ättachemnt -- can you rename it to ättachment instead, so that it's spelled correctly?

[item4]

fixed

[singingwolfboy]

Great, thank you so much! ✨