Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with Page.source_filename, Page.iter_source_filenames with alternatives are enabled #959

Closed
wants to merge 10 commits into from
Closed

Problems with Page.source_filename, Page.iter_source_filenames with alternatives are enabled #959

wants to merge 10 commits into from

Commits on Dec 13, 2021

  1. Tests for correct source_filename, iter_source_filenames

    @dairiki
    dairiki committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    a12f349 View commit details
    Browse the repository at this point in the history

  2. WIP: deprecate .source_filename, cleanup .iter_source_filenames 

    When alts are enabled, Page.source_file was being generated based on
the page.alt.  This is not correct, since the alt-specific file may
not exists.  E.g. if there is only a `contents.lr`, for `alt="en"`
`source_file` was returning the non-existent file `contents+en.lr`.

In general, `.source_filename` and `.iter_source_filenames` should
return only extant source filenames.

Dependency tracking for the blog pages of the example site is not
working.  They get rebuilt every build.  This has something to do with
the `Siblings` virtual source object for the blog pages not listing
the correct source filenames due to the issue with Page.source_file
described above.
    @dairiki
    dairiki committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    3296213 View commit details
    Browse the repository at this point in the history

  3. Update CHANGES

    @dairiki
    dairiki committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    a4880fb View commit details
    Browse the repository at this point in the history

  4. Fix Alt.exists to track fixes to Page.source_filename

    @dairiki
    dairiki committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8ab126c View commit details
    Browse the repository at this point in the history

  5. Fix Asset.iter_source_filenames to track changes to SourceObj

    @dairiki
    dairiki committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    9ed30c5 View commit details
    Browse the repository at this point in the history

  6. Delete unused private function lektor.db._is_content_file

    @dairiki
    dairiki committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    c6c3e17 View commit details
    Browse the repository at this point in the history

  7. fixup! WIP: deprecate .source_filename, cleanup .iter_source_filenames 

    Refactor to add _source_filenames in lieu of _source_alts system field.
    @dairiki
    dairiki committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    1766ed4 View commit details
    Browse the repository at this point in the history

  8. fixup! Update CHANGES

    @dairiki
    dairiki committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    d14a045 View commit details
    Browse the repository at this point in the history

  9. Hash return value of Siblings.get_checksum. General code cleanup. 

    There's no point in storing the huge long string containing multiple
file names and hashes in the build state db.
    @dairiki
    dairiki committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8084635 View commit details
    Browse the repository at this point in the history

  10. Update CHANGES

    @dairiki
    dairiki committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    69141a9 View commit details
    Browse the repository at this point in the history