Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated thumbnailing features #960

Conversation

dairiki
Copy link
Contributor

@dairiki dairiki commented Dec 13, 2021

This PR does two things:

  • It removes the deprecated crop argument from the Image.thumbnail() method.
  • It disables implicit thumbnail upscaling.

Currently, warnings are emitted when either of those deprecated features are used. They have been deprecated since the 3.2.0 release.

When the time is right, here is the PR to remove those features.

Issue(s) Resolved

Fixes #930

Related Issues / Links

Description of Changes

  • Added unit test(s) covering the changes (if testable)
  • Link to corresponding documentation pull request for getlektor.com

@dairiki dairiki force-pushed the feature.930-remove-deprecated-thumbnail-features branch from 79904cb to 76635bc Compare August 2, 2022 21:58
@dairiki dairiki merged commit bd43c83 into lektor:master Aug 2, 2022
@dairiki dairiki deleted the feature.930-remove-deprecated-thumbnail-features branch August 3, 2022 05:06
dairiki added a commit to dairiki/lektor that referenced this pull request Feb 25, 2023
This test should have been enabled when PR lektor#960 was merged.
dairiki added a commit to dairiki/lektor that referenced this pull request Feb 26, 2023
This test should have been enabled when PR lektor#960 was merged.
dairiki added a commit to dairiki/lektor that referenced this pull request Sep 11, 2023
This test should have been enabled when PR lektor#960 was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable deprecated implicit thumbnail upscaling?
1 participant