Update .travis.yml #101
Update .travis.yml #101
Conversation
The build is failing because travis fails to build yoga-layout from react-sketchapp, which is a dependency of this project. The way react-sketchapp builds is they do it osx.
|
Almost there. This failure is related to a "comma-dangle" in my other pull request. |
This will hopefully fix the build in lelandrichardson#101
.travis.yml
Outdated
| before_script: | ||
| - 'sh -e /etc/init.d/xvfb start' | ||
| #before_script: | ||
| # - 'sh -e /etc/init.d/xvfb start' |
There was a problem hiding this comment.
what was this doing?
There was a problem hiding this comment.
Truth be told it's the first time I see this.
http://semicomplete.com/blog/geekery/xvfb-firefox.html shows how to use it to create screenshots.
But I don't see where jest is actually using it.
There was a problem hiding this comment.
0327145#diff-354f30a63fb0907d4ad57269548329e3 Introduced happo, which is for in browser testing.
Then later travis script switched to jest and linting, but happo was not cleaned up.
| # https://github.com/SeleniumHQ/selenium/issues/2559 | ||
| firefox: "47.0.1" | ||
| before_script: | ||
| - 'sh -e /etc/init.d/xvfb start' |
There was a problem hiding this comment.
visual diffs were not running on travis since 678703e
There was a problem hiding this comment.
I don't think happo was run on the CI 🤔
There was a problem hiding this comment.
what happens if we change the travis script to npm run --silent test && npm run --silent lint && npm run --silent happo (and keep the firefox and xvfb)?
There was a problem hiding this comment.
react-sketchapp used to fail on ubuntu, which is why i switched it to osx. Xvfb is not available on osx travis-ci/travis-ci#7277
There was a problem hiding this comment.
@mathieudutour what about the build status?
Visual diffs with happo have been disabled for a while. I assume because they are broken. React sketchapp does not build on linux. The happo script does not work on osx.
I think in the interest of the value provided by the successfulness of build status, react primitives should give up the idea of visual diffs for now. And bring it back in a more cross platform way.
The build is failing because travis fails to build yoga-layout from react-sketchapp, which is a dependency of this project.
The way react-sketchapp builds is they do it osx.