Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .travis.yml #101

Merged
merged 3 commits into from
Jun 17, 2018
Merged

Update .travis.yml #101

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5517509
Update .travis.yml
Hermanya Feb 3, 2018
92e46ef
Update .travis.yml
Hermanya Feb 3, 2018
412b231
Update .travis.yml
Hermanya Feb 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
sudo: false
os: osx
osx_image: xcode8.2
language: node_js
node_js:
- "6"
addons:
# This is the latest version of Firefox that currently supports Happo.
# https://github.com/SeleniumHQ/selenium/issues/2559
firefox: "47.0.1"
before_script:
- 'sh -e /etc/init.d/xvfb start'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing happo will kill visual diffs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visual diffs were not running on travis since 678703e

Copy link
Collaborator

@mathieudutour mathieudutour Feb 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think happo was run on the CI 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if we change the travis script to npm run --silent test && npm run --silent lint && npm run --silent happo (and keep the firefox and xvfb)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-sketchapp used to fail on ubuntu, which is why i switched it to osx. Xvfb is not available on osx travis-ci/travis-ci#7277

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathieudutour what about the build status?
Visual diffs with happo have been disabled for a while. I assume because they are broken. React sketchapp does not build on linux. The happo script does not work on osx.
I think in the interest of the value provided by the successfulness of build status, react primitives should give up the idea of visual diffs for now. And bring it back in a more cross platform way.

script:
- 'npm run travis'