Fix upgrade to react-native-web@0.2.2 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is on npm untill the react-native-web upgrade is in, as |
Closed
|
@lelandrichardson could this be merged? Would be a very useful update. |
|
This package have a very light activity. You should not expect response until it's a BIG deal. Which doesn't seems to be the case. |
|
It seems more important to ppl that rest of support for React 16 get in, rather than react-native-web get upgraded to the latest. Thats why I just focused on 0.2.2, like the other PR had |
|
It is awesome PR! I am waiting to be merged! 👍 |
This was referenced Jan 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit on top of #97 to have it pass the tests