Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce LongVariableByte #55

Merged
merged 6 commits into from Nov 28, 2022
Merged

Conversation

blacelle
Copy link
Collaborator

Should cover #30 with a with LongCODEC: LongVariableByte

@blacelle
Copy link
Collaborator Author

@lemire Please have a look.

@lgtm-com
Copy link

lgtm-com bot commented Nov 26, 2022

This pull request introduces 12 alerts when merging bb82f92 into 16a89d7 - view on LGTM.com

new alerts:

  • 10 for Left shift by more than the type width
  • 2 for Useless comparison test

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@blacelle
Copy link
Collaborator Author

LGTM.com will be shut down in December 2022

Oh. https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/

@lemire
Copy link
Owner

lemire commented Nov 28, 2022

It is amazing !!! Let us run the tests !

@lemire
Copy link
Owner

lemire commented Nov 28, 2022

Merging.

@lemire lemire merged commit 87cc59d into lemire:master Nov 28, 2022
@lemire
Copy link
Owner

lemire commented Nov 28, 2022

Fantastic!

@blacelle blacelle deleted the IntroduceLongCompression branch November 28, 2022 15:23
@blacelle
Copy link
Collaborator Author

Wow. Wait ! xD

LongBinaryPacking is in the pipe. I may also have wanted to discuss some of the changes (as some choices may be debatable).

@lemire
Copy link
Owner

lemire commented Nov 28, 2022

@blacelle I am not going to issue a release any time soon. You should have access to the repo.

@lemire
Copy link
Owner

lemire commented Nov 28, 2022

Just issue a new PR !

❤️

@lemire
Copy link
Owner

lemire commented Nov 28, 2022

To handle negative longs, one should use zigzag... We don't have an implementation for longs currently, I think, but it would not be difficult to produce.

@lemire
Copy link
Owner

lemire commented Nov 28, 2022

I cleaned some other minor issues in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants