Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TransformedKNeighborsMixin.predict to avoid double transformation #25

Merged
merged 1 commit into from
May 25, 2023

Conversation

grovduck
Copy link
Member

Resolves #23. The discussion there gives good background and an explanation of this fix.

@grovduck grovduck self-assigned this May 25, 2023
@grovduck grovduck added the bug Something isn't working label May 25, 2023
@aazuspan
Copy link
Contributor

LGTM!

@grovduck grovduck merged commit 4828023 into fb_add_estimators May 25, 2023
@grovduck grovduck deleted the fix-double-transformation branch May 25, 2023 21:15
@grovduck grovduck removed their assignment Jun 7, 2023
@grovduck grovduck linked an issue Jun 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted double transformation using TransformedKNeighborsMixin.predict
2 participants