Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hack, canot use statelessComponent #7

Closed
brauliodiez opened this issue Mar 10, 2016 · 1 comment
Closed

Remove hack, canot use statelessComponent #7

brauliodiez opened this issue Mar 10, 2016 · 1 comment
Assignees

Comments

@brauliodiez
Copy link
Member

Right now on the definition of

class MemberPage extends React.Component<Props, {}> {

We are using React.Component, we should be using React.StatelessComponent, if we make this change we get an error, we had to rollback to React.Component, and add an ugly hack when gluing the reducer:


// TODO: Hack to bypass the issue when declaring StateLessComponent
// Pending research here
var nonTypedMemberPage : any = MemberPage;

const ContainerMemberPage = connect(
                                   mapStateToProps
                                  ,mapDispatchToProps
                                )(nonTypedMemberPage)

We need to unsderstand what's going on here and how this could be fixed, found in stackoverflow that we should upgrade to typescript 1.8 in order to fix that done but no luck, maybe is just the tsd that is not well defined.

@nasdan
Copy link
Member

nasdan commented Mar 14, 2016

This issue was resolved in #8 Redux support. Before that is not needed.

@nasdan nasdan closed this as completed Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants