Use typesafe domain #125
Merged
Use typesafe domain #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And rename Natural to PositiveInt
lenguyenthanh
force-pushed
the
refactor/3-typesafe-domain
branch
from
357bc9d
to
14fe084
Compare
lenguyenthanh
force-pushed
the
refactor/3-typesafe-domain
branch
from
14fe084
to
1cbd9b5
Compare
lenguyenthanh
force-pushed
the
refactor/3-typesafe-domain
branch
from
e3cfa9c
to
cdfb252
Compare
lenguyenthanh
commented
Jun 9, 2024
| val sorting = Models.Sorting.fromOption(sortBy.map(_.to[Models.SortBy]), order.map(_.to[Models.Order])) | ||
| val filter = Models.PlayerFilter( | ||
| isActive, | ||
| Models.RatingRange(standardMin.map(_.value), standardMax.map(_.value)), |
There was a problem hiding this comment.
Use mixing to avoid duplicated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.