Add desc indexes to optimize desc query #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have stress testing, therefore We could find performance issue like this.
With the tests, I noticed a significant performance dropped on some query (look at warmup tests before image), then after some search the fix is quite easy: It just needs some more indexes in our database.
With this small changes the improve in performance is staggering.
With
Stress Simulation
test, the at 99% tile, it is 2000% faster and 3000% time faster inmean
value.With
Capacity Simulation
test, the failed requests are reduce from 81% to 0%, and there is almost no different between 0 rps and 240 rps.So, these stress tests are meaningless now, I'll increase load for these stress tests in another PR.
Screenshot of the results before and after:
Before:
After:
Before:
After:
Before:
After: