Feat: PHP8 / Symfony 5+ support

[bpolaszek]

This PR adds support for PHP8 and Symfony 5+, by bumping minimal PHP version to 7.1 and adding return types.
Hence it also drops support for older Symfony versions, and will require a new major release as some BC breaks are expected.

[lennerd]

Wow, awesome! Thanks for putting this together. Will review this ASAP.

[bpolaszek]

Looks like Travis isn't triggered. Do you want to keep it or do you want me to switch this repo to Github Actions?

[coveralls]

Coverage increased (+1.1%) to 96.875% when pulling 1adaa71 on bpolaszek:feat/php8-sf5 into b35c10c on lennerd:master.

[lennerd]

I had a first change to look at the code. Over all LGTM (see comments, questions, requests). Again thanks for the time you spend updating all classes and especially the tests. 👍

Next (probably in the evening) I will look at the Travis setup. Looks like there is some configuration missing or which at least needs to be fixed. Will keep you posted.

[lennerd]

Replaced Travis CI setup with Github Actions. Let me know what you think.

[bpolaszek]

Hi @lennerd,

Sorry, still didn't have the time to review your review, but I don't forget it, it's still in my todos.

Thanks!

[bpolaszek]

Done, finally :-)

[bpolaszek]

Rebased + updated Github Actions config.

[lennerd]

@bpolaszek not sure how Github send notifications about failed checked. So in case you didn't notice … 😬 😉

[bpolaszek]

Hey @lennerd - sorry I keep snoozing that one 😞
I'm not currently available to work on this at the very moment, but don't hesitate to harass me if you don't get any news until next month.

Thanks!
Ben

[lennerd]

No problem and thanks for letting me know. Will notify you next month if needed. 😉

[bpolaszek]

Hey @lennerd - I just took a quick look again and CI fails because Symfony's config component LoaderInterface::load has changed its signature from 4.4 to 5.0.

• 4.4 version
• 5.0 version

So, either we have to maintain 2 distinct implementations of YamlLoader (and properly detect what version of the Config component is used) which is a PITA, or, ship a 2.1 version dropping Symfony 4 support (and I'd advocate for dropping PHP < 7.4 support as well, since older versions are EOLed).

WDYT?

[bpolaszek]

I dropped PHP < 7.4 support as well as Symfony < 5.
This would require a major version bump. CI passes. WDYT?

[bpolaszek]

Ping @lennerd :-)

[lennerd]

@bpolaszek sorry for the long delay! And thanks again for all the changes. Everything looks good so far.

My problem is I haven‘t used this library nor Symfony or even PHP for a very long time. So to be honest maintaing this project is not my top priority anymore. But, I might have a wild idea.

What do you think about beeing a contributer to this project? As a first act you could merge this PR. 🙂

[bpolaszek]

Hi @lennerd,

No worries, I understand 🙂
Sure, I'll do my best to keep it up 👍

[lennerd]

@bpolaszek Nice. 👍 Invitation should be on it‘s way. Let me know if this works for you.

[bpolaszek]

@lennerd sounds good 🙂 may I push the button? I usually use the "squash/merge" option in github in my other projects, but if you prefer merge commits, please let me know. Thanks again! 🙏

[lennerd]

You may! 🙂 In the meantime I also prefer squash and merge.

So I would say, go for it!

[bpolaszek]

Here we go! 🎉