App crash when pod log open, with "Show Timestamps" enabled

[shripadk]

Describe the bug
Had a pod log open with Show Timestamps enabled. The app crashed after a while (checked it after unlocking my Mac from sleep).

Expected behavior
App shouldn't crash

Screenshots
Get the following error:

Environment (please complete the following information):

• Lens Version: 4.2.0
• Electron: 9.4.0
• Chrome: 83.0.4103.122
• Node: 12.14.1
• OS: macOS Mojave 10.14.6 (18G8022)
• Installation method (e.g. snap or AppImage in Linux): Lens-4.2.0.dmg

[jim-docker]

Can you reproduce this? Wondering if it is more related to coming out of sleep than the pod logs.

[shripadk]

@jim-docker I tried reproducing it but wasn't successful. Haven't had this bug crop up since. But if it happens again I'll definitely post an update here.

[david-in-perth]

FYI: I just encountered this in Linux (Ubuntu).

I had a pod log window open (with timestamps enabled), but hadn't looked at it since about a day ago.
A few minutes ago, I used Reload (View > Reload or Ctrl+R, I can't remember which),
and got an app crash screen more-or-less the same as the OP (except the path in the URL is /jobs).

App crash at http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/jobs

Component stack:

    at RF (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:8287800)
    at div
    at div
    at xF (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:8293971)
    at footer
    at div
    at IU (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:8498815)
    at AA (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:7675741)
    at t (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:222042)
    at kU (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:8500319)

Error stack:

TypeError: Cannot read property 'showTimestamps' of undefined
    at RF.renderResourceSelector (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:8288622)
    at RF.render (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:8289137)
    at Ce (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:13973)
    at http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:7531713
    at ce (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:12079)
    at e.track (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:23443)
    at RF.s [as render] (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:7531661)
    at RF.Ee (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:7531809)
    at RF.t.render (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:7530765)
    at _s (http://e2eda300-b5d0-4889-8971-42ea56ec683c.localhost:44793/build/Lens.js:2:4631182)

Environment:

• Lens Version: 4.2.1
• Electron: 9.4.0
• Chrome: 83.0.4103.122
• Node: 12.14.1
• OS: Ubuntu 20.04.2 LTS (upgraded from Ubuntu 18.04)
• Installation method (e.g. snap or AppImage in Linux): snap

[david-in-perth]

@jim-docker : I've reproduced it multiple times using "reload" (Ctrl+R).

I've been closing and reopening Lens and trying various experiments before reloading, and it seems to cause a crash in a variety of different circumstances.

Here are some examples that seem to be consistent behaviour:

• Open log window for a pod; Quit Lens; Start Lens; Lens opens cluster; Lens restores previously open log window; Press Ctrl+R.
  • Result: Crashed every time so far
• Quit Lens while no log windows are open; Start Lens; Lens opens cluster; Press Ctrl+R.
  • Result: No crash so far
• Quit Lens while no log windows are open; Start Lens; Lens opens cluster; Open log window for a pod; Press Ctrl+R.
  • Result: In most cases, it crashed, but in a few cases it didn't (I haven't identified a pattern yet)

I didn't touch the show-timestamps button in any of the above tests.

Hopefully this is enough for someone else to reproduce.

[Nokel81]

Fixed by #2566

[david-in-perth]

Note for future reference: As covered in #2652, this error still occurs in Lens 4.2.5. A fix (#2959) was included in 5.0.0.