Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: logs data disapearing causing crashes #2566

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Apr 19, 2021

I guess that it would better to figure out why the DockTabStore is loosing information. Any ideas @ixrock ? Could it be that the OS is deleting a cache file?

Signed-off-by: Sebastian Malton sebastian@malton.name

fixes: #2458

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added bug Something isn't working merge/master This PR will need to be merged to master after merged to target. Using cherry-pick. labels Apr 19, 2021
@Nokel81 Nokel81 added this to the 4.2.3 milestone Apr 19, 2021
@Nokel81 Nokel81 requested a review from a team April 19, 2021 15:35
@Nokel81 Nokel81 self-assigned this Apr 19, 2021
@Nokel81 Nokel81 requested review from ixrock and jim-docker and removed request for a team April 19, 2021 15:35
@jim-docker
Copy link
Contributor

Is @aleksfront also working on a fix for this?

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Apr 21, 2021

@jim-docker I don't know, I told him about this PR but he didn't respond.

Copy link
Contributor

@aleksfront aleksfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jim-docker jim-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Couldn't reproduce the error before (or after) this fix

@Nokel81 Nokel81 merged commit fa2acc3 into release/v4.2 Apr 26, 2021
@Nokel81 Nokel81 deleted the issue-2458 branch April 26, 2021 13:34
@Nokel81 Nokel81 mentioned this pull request Apr 26, 2021
Nokel81 added a commit that referenced this pull request Apr 26, 2021
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 mentioned this pull request Apr 26, 2021
@Nokel81 Nokel81 removed the merge/master This PR will need to be merged to master after merged to target. Using cherry-pick. label Apr 26, 2021
Nokel81 added a commit that referenced this pull request Apr 26, 2021
Signed-off-by: Sebastian Malton <sebastian@malton.name>
jakolehm pushed a commit that referenced this pull request Apr 27, 2021
* Fix: logs data disapearing causing crashes (#2566)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Refactor helm-chart.api and improve kube validation and error handling (#2265)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix: HPA's not sortable by age (#2565)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Conditionally render status icon for kube meta (#2298)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix custom resource loading spinner appears above extensions' cluster menus (#2344)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Lens should point to the release docs (#2268)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Refactor the Extensions settings page (#2221)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* try and get jest to not core dump

Signed-off-by: Sebastian Malton <sebastian@malton.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants