Pod logs refactoring #1516
Pod logs refactoring #1516
Conversation
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
| this.isJumpButtonVisible = false; | ||
| } | ||
| if (!logs.length) { | ||
| this.isLastLineVisible = false; |
There was a problem hiding this comment.
This field really sounds like it is computed. Shouldn't it be marked as such?
There was a problem hiding this comment.
I don't think so. This is an observable flag not really different from other ones like isJumpButtonVisible. A computed is used to calculate some value from other observables. isLastLineVisible just holds bool value and doesn't need to be "computed".
| reaction(() => this.props.tab.id, async () => { | ||
| await this.load(); | ||
| this.scrollToBottom(); | ||
| await this.reload(); | ||
| }, { fireImmediately: true }), |
There was a problem hiding this comment.
Couldn't we just pass this.reload to the reaction directly?
There was a problem hiding this comment.
Can you elaborate this a bit please?
There was a problem hiding this comment.
Sure. It seems like we have the following snippet. async () => { await this.reload(); }. I wonder if we could instead just have, this.reload if it has been marked with @autobind().
There was a problem hiding this comment.
Yes, it works as expected. Thanks for review!
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Refactoring log components by spreading
PodLogsmonolith to logical and presentational ones.Also fixing founded bugs including: