Add extension-api facades to cluster & workspace stores #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
jakolehm
added
area/extension
|
I like the idea. With this we can refactor internal store without breaking the Extensions API and we don't need to expose all internal methods to extensions. |
Nokel81
reviewed
Nov 27, 2020
| /** | ||
| * Active cluster id | ||
| */ | ||
| activeClusterId = internalClusterStore.activeCluster; |
There was a problem hiding this comment.
have you tested that this works? When I was thinking about it yesterday I wasn't convinced that this would work and that we would have to do something like the following:
Suggested change
| activeClusterId = internalClusterStore.activeCluster; | |
| get activeClusterId() { | |
| return internalClusterStore.activeCluster; | |
| } | |
| set activeClusterId(newId: string) { | |
| internalClusterStore.activeCluster = newId; | |
| } |
There was a problem hiding this comment.
get/set is better.
Nokel81
approved these changes
Nov 27, 2020
jakolehm
added
bug
jakolehm
deleted the
fix/stop-leaking-cluster-and-workspace-store-internals
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Cluster and Workspace stores currently leak internals to extension-api. This PR adds a facade store for both of them and exposes only usable apis.
This also allows us to work more freely on store internals (we only expose apis explicitly). Good example of accidental leaks is #1453 .