New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation refactoring, handling extension page params #1651
Conversation
Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviews some of these changes. I will continue the review tomorrow. But there are some things already that need to be changed.
Besides all technical details and breaking changes.. what do you think about the concept? |
Signed-off-by: Roman <ixrock@gmail.com>
…params Signed-off-by: Roman <ixrock@gmail.com>
…page-params registration Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
…am => createPageParam (helper) Signed-off-by: Roman <ixrock@gmail.com>
# Conflicts: # src/renderer/components/app.tsx
Signed-off-by: Roman <ixrock@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good change, but I think the interface could be improved a bit.
# Conflicts: # src/renderer/components/+workloads-replicasets/replicasets.tsx # src/renderer/components/+workloads/workloads.tsx
Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR breaks the foldout menu feature (using id
/parentId
fields of the ClusterPageMenuRegistration
interface). I have examples that work in master but not in this branch.
# Conflicts: # src/renderer/components/layout/sidebar.tsx
Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
@jim-docker could you please check this one more time? I've merged |
Yes, works again 👍 |
# Conflicts: # src/renderer/components/+namespaces/namespace.store.ts
# Conflicts: # src/renderer/components/+workloads-pods/pods.tsx
renderer/navigation.ts
with new helperNavigation.createPageParam({name: string, defaultValue?: any, parse?(), stringify?(), ...})
pageInit.id
stops supporting dynamic param placeholders, e.g./users/:user
pageInit.exact
option removedclose #1399
Example from
extensions/example-extension/renderer.tsx
: