Move cluster related types and function into seperate files #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
requested review from
jakolehm and
jim-docker
and removed request for
a team
This was referenced Jul 29, 2021
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
panuhorsmalahti
previously approved these changes
Aug 2, 2021
nevalla
previously approved these changes
Aug 3, 2021
- This is with a mind to ban circular dependencies - With this change all the types and helper functions can be imported from anywhere without circular imports Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
nevalla
approved these changes
Aug 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is with a mind to ban circular dependencies
With this change all the types and helper functions can be imported
from anywhere without circular imports
Signed-off-by: Sebastian Malton sebastian@malton.name
Part of splitting apart #3410