Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Hotbar types to seperate file #3532

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Move Hotbar types to seperate file #3532

merged 2 commits into from
Aug 3, 2021

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Jul 29, 2021

Signed-off-by: Sebastian Malton sebastian@malton.name

Blocked by #3530

@Nokel81 Nokel81 added the chore label Jul 29, 2021
@Nokel81 Nokel81 added this to the 5.2.0 milestone Jul 29, 2021
@Nokel81 Nokel81 self-assigned this Jul 29, 2021
@Nokel81 Nokel81 mentioned this pull request Jul 30, 2021
9 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Nokel81 Nokel81 removed their assignment Aug 3, 2021
Base automatically changed from cluster-types to master August 3, 2021 14:36
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 marked this pull request as ready for review August 3, 2021 14:38
@Nokel81 Nokel81 requested a review from a team as a code owner August 3, 2021 14:38
@Nokel81 Nokel81 requested review from nevalla and aleksfront and removed request for a team August 3, 2021 14:38
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

Conflicts have been resolved. A maintainer will review the pull request shortly.

jim-docker
jim-docker previously approved these changes Aug 3, 2021
src/common/hotbar-store.ts Outdated Show resolved Hide resolved
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Copy link
Contributor

@jim-docker jim-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would I see the "Default" hotbar in Lens?

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Aug 3, 2021

When would I see the "Default" hotbar in Lens?

On a fresh install of lens, though the "default" hotbar from src/migrations/hotbar-store/5.0.0-alpha.0.ts might be shown instead. Perhaps I should change that name too?

@Nokel81 Nokel81 merged commit 3fe8014 into master Aug 3, 2021
@Nokel81 Nokel81 deleted the hotbar-types branch August 3, 2021 18:38
@Nokel81 Nokel81 mentioned this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants