Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial tweaks accidentally left from other PR #5679

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

jansav
Copy link
Contributor

@jansav jansav commented Jun 20, 2022

Tweaks accidentally left from PR #5662

  1. Remove dead code
  2. Consolidate naming
  3. Tweak scope of MobX action

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
@jansav jansav added the chore label Jun 20, 2022
@jansav jansav added this to the 5.6.0 milestone Jun 20, 2022
@jansav jansav requested a review from a team as a code owner June 20, 2022 07:25
@jansav jansav requested review from nevalla and Nokel81 and removed request for a team June 20, 2022 07:25
@jansav
Copy link
Contributor Author

jansav commented Jun 20, 2022

Failing unit test is unrelated.

@Nokel81 Nokel81 merged commit f8b0086 into master Jun 20, 2022
@Nokel81 Nokel81 deleted the chore/small-consolidation branch June 20, 2022 15:50
@jansav jansav mentioned this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants