-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old workaround to append clusterUrl in resolveAuthProxyUrl() #5833
Conversation
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this fixes the terminal issues.
This just highlights the fact that we need to add behaviours here soon. It feels like we don't know how it should work at the moment, which isn't very good thing. :) |
@jansav should we update the lens for resolving this issue or is that expected to work in current release? We are facing the terminal issues. |
@Nokel81 @jim-docker @jansav can you please let me know if this fixes #5829 , If yes, can we try on the same version or is that expected to upgrade lens? |
@skri547 We think that this should fix that issue. You would need to upgrade Lens, but this fix has currently not been released even in an alpha. |
@Nokel81 by when or which release it will be available for everyone? Any ETA? |
Another alpha should be produced this week. With general availability in the new few weeks. |
How can i download or upgrade the lens to Alpha to try this in Windows desktop? |
When it comes out, you can change the release channel in your preferences and then "check for updates" via the tray menu. |
A similar code fragment was removed in #5550. It's not clear why this code was needed. @jakolehm can you confirm if this is part of the same workaround that is no longer needed? (as stated here: #5550 (review))
fixes #5663
also may fix #5658 and fix #5628
Before this fix this was the kind of pathname going through the auth proxy:
The clusterUrl,
k8s/clusters/local
being extraneous and causing a Bad Gateway response.needs more testing to confirm it doesn't cause regressiontried local, spaces, aws clusters, no issues. Others should test...