Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renderer file logging through IPC #7499

Merged
merged 14 commits into from
Apr 4, 2023
Merged

Renderer file logging through IPC #7499

merged 14 commits into from
Apr 4, 2023

Commits on Apr 3, 2023

  1. Renderer file logging through IPC 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    d3cc345 View commit details
    Browse the repository at this point in the history

  2. Remove pagehide event listener as it may cause UI to freeze 

    Pagehide was needed in cluster frame to better handle main frame close/reload situation. But even empty pagehide listener in cluster frame seems to freeze the UI at least on some situations (multiple clusters open).

Beforeunload is not always executed in cluster frame when main frame is reloaded/closed, leaving log files open. To fix that, `stopIpcLoggingInjectable` is introduced to close all log files.

Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    42081df View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary formatting changes 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    22bcbad View commit details
    Browse the repository at this point in the history

  4. Lint fix 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    c25b24d View commit details
    Browse the repository at this point in the history

  5. Winston logger override 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    262f3de View commit details
    Browse the repository at this point in the history

  6. Remove usage of doGeneralOverrides as it has been removed 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    d3a3cdd View commit details
    Browse the repository at this point in the history

  7. Update imports to match the new base 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    6b38d0f View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary id 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    a9cd2e1 View commit details
    Browse the repository at this point in the history

  9. Review improvements 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    91a40c6 View commit details
    Browse the repository at this point in the history

  10. Extract beforeunload listener to injectable 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    39057ca View commit details
    Browse the repository at this point in the history

  11. Typo fix 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    457dfc4 View commit details
    Browse the repository at this point in the history

  12. Behavioural tests and log file rename 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    10d3539 View commit details
    Browse the repository at this point in the history

  13. Update messaging to work with new base 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    dcdba45 View commit details
    Browse the repository at this point in the history

  14. Move files to feature 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9209882 View commit details
    Browse the repository at this point in the history