Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove incorrect KubeObject validations #7771

Merged
merged 5 commits into from May 25, 2023
Merged

fix: Remove incorrect KubeObject validations #7771

merged 5 commits into from May 25, 2023

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented May 24, 2023

Error in console:

> await podMetricsApi.list({ name: "cert-manager-webhook-549c989579-sjkkk", namespace: "cert-manager" })
renderer.js:102558 Uncaught Error: Cannot create a KubeObject from an object without metadata.uid being a string
    at new P (renderer.js:102558:5777)
    at new oe (renderer.js:102558:36682)
    at renderer.js:14735:1
    at Array.map (<anonymous>)
    at PodMetricsApi.parseResponse (renderer.js:14728:1)
    at PodMetricsApi.list (renderer.js:14771:1)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async <anonymous>:1:1

@Nokel81 Nokel81 added the bug Something isn't working label May 24, 2023
@Nokel81 Nokel81 added this to the 6.5.0 milestone May 24, 2023
@Nokel81 Nokel81 requested a review from a team as a code owner May 24, 2023 14:20
@Nokel81 Nokel81 requested review from Iku-turso and jim-docker and removed request for a team May 24, 2023 14:20
@Nokel81 Nokel81 force-pushed the remove-kube-object-checks branch from 96ff127 to 67f67b4 Compare May 24, 2023 14:45
@Nokel81
fix: Remove incorrect KubeObject validations
9bbc988 
- Default to using the ensured selfLink for ID if UID is not present

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 force-pushed the remove-kube-object-checks branch from 67f67b4 to 9bbc988 Compare May 24, 2023 19:33
@Nokel81
chore: Fixup use of ServiceAccount to use getId
219195b 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
chore: Improve KubeObject tests
1a5a3b7 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
chore: Simplify KubeObject tests to use stub data
046d8a5 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
chore: Rename KubeObject tests to better clarity
82121a4 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 merged commit 4e6b51e into master May 25, 2023
15 checks passed
@Nokel81 Nokel81 deleted the remove-kube-object-checks branch May 25, 2023 13:51
@k8slens-bot k8slens-bot mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-docker jim-docker jim-docker left review comments

@Iku-turso Iku-turso Iku-turso approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nokel81 @Iku-turso @jim-docker