fix: Remove incorrect KubeObject validations

packages/core/src/renderer/components/user-management/cluster-role-bindings/dialog/view.tsx

@@ -86,7 +86,7 @@ class NonInjectedClusterRoleBindingDialog extends React.Component<ClusterRoleBin
   }
 
   @observable selectedRoleRef: ClusterRole | undefined = undefined;
-  selectedAccounts = new ObservableHashSet<ServiceAccount>([], sa => sa.metadata.uid);
+  selectedAccounts = new ObservableHashSet<ServiceAccount>([], sa => sa.getId());
   selectedUsers = observable.set<string>([]);
   selectedGroups = observable.set<string>([]);
 

packages/core/src/renderer/components/user-management/role-bindings/dialog/view.tsx

@@ -73,7 +73,7 @@ class NonInjectedRoleBindingDialog extends React.Component<RoleBindingDialogProp
   @observable.ref selectedRoleRef: Role | ClusterRole | null | undefined = null;
   @observable bindingName = "";
   @observable bindingNamespace: string | null = null;
-  selectedAccounts = new ObservableHashSet<ServiceAccount>([], sa => sa.metadata.uid);
+  selectedAccounts = new ObservableHashSet<ServiceAccount>([], sa => sa.getId());
   selectedUsers = observable.set<string>([]);
   selectedGroups = observable.set<string>([]);
 

packages/kube-object/src/api-types.ts

@@ -25,8 +25,8 @@ export interface KubeJsonApiData<
   Status = unknown,
   Spec = unknown,
 > {
-  kind: string;
-  apiVersion: string;
+  readonly kind: string;
+  readonly apiVersion: string;
   metadata: Metadata;
   status?: Status;
   spec?: Spec;
@@ -227,9 +227,6 @@ export type KubeJsonApiObjectMetadata<Namespaced extends KubeObjectScope = KubeO
 export type KubeObjectMetadata<Namespaced extends KubeObjectScope = KubeObjectScope> =
   KubeJsonApiObjectMetadata<Namespaced> & {
     readonly selfLink: string;
-    readonly uid: string;
-    readonly name: string;
-    readonly resourceVersion: string;
   };
 
 export type NamespaceScopedMetadata = KubeObjectMetadata<KubeObjectScope.Namespace>;

packages/kube-object/src/kube-object.test.ts

@@ -0,0 +1,72 @@
+import { KubeObject } from "./kube-object";
+
+const getStubData = () => ({
+  apiVersion: "metrics.k8s.io/v1beta1",
+  kind: "PodMetrics",
+  metadata: {
+    creationTimestamp: "2023-05-24T14:17:01Z",
+    name: "cert-manager-54cbdfb45c-n4kp9",
+    namespace: "cert-manager",
+    selfLink: "/apis/metrics.k8s.io/v1beta1/namespaces/cert-manager/pods/cert-manager-54cbdfb45c-n4kp9",
+    uid: "123" as string | undefined,
+    resourceVersion: "foobar" as string | undefined,
+  },
+});
+
+describe("kube object tests", () => {
+  it("given '.metadata.uid' is missing, then KubeObject constructor does not throw", () => {
+    const data = getStubData();
+
+    delete data.metadata.uid;
+    expect(() => new KubeObject(data)).not.toThrow();
+  });
+
+  it("given '.metadata.resourceVersion' is missing, then KubeObject constructor does not throw", () => {
+    const data = getStubData();
+
+    delete data.metadata.resourceVersion;
+    expect(() => new KubeObject(data)).not.toThrow();
+  });
+
+  it("given both '.metadata.resourceVersion' and '.metadata.uid' are missing, then KubeObject constructor does not throw", () => {
+    const data = getStubData();
+
+    delete data.metadata.uid;
+    delete data.metadata.resourceVersion;
+    expect(() => new KubeObject(data)).not.toThrow();
+  });
+
+  it("given '.metadata.uid' exist, then KubeObject.getId() should return it", () => {
+    const data = getStubData();
+    const obj = new KubeObject(data);
+
+    expect(obj.getId()).toEqual("123");
+  });
+
+  it("given '.metadata.uid' is missing, then KubeObject.getId() should return '.metadata.selfLink'", () => {
+    const data = getStubData();
+
+    delete data.metadata.uid;
+    const obj = new KubeObject(data);
+
+    expect(obj.getId()).toEqual(
+      "/apis/metrics.k8s.io/v1beta1/namespaces/cert-manager/pods/cert-manager-54cbdfb45c-n4kp9",
+    );
+  });
+
+  it("given '.metadata.resourceVersion' exist, then KubeObject.getResourceVersion() should return it", () => {
+    const data = getStubData();
+    const obj = new KubeObject(data);
+
+    expect(obj.getResourceVersion()).toEqual("foobar");
+  });
+
+  it("given '.metadata.resourceVersion' is missing, then KubeObject.getResourceVersion() should return an empty string", () => {
+    const data = getStubData();
+
+    delete data.metadata.resourceVersion;
+    const obj = new KubeObject(data);
+
+    expect(obj.getResourceVersion()).toEqual("");
+  });
+});

packages/kube-object/src/kube-object.ts

@@ -111,20 +111,6 @@ export class KubeObject<
       );
     }
 
-    if (!isString(data.metadata.uid)) {
-      throw new KubeCreationError(
-        `Cannot create a KubeObject from an object without metadata.uid being a string`,
-        data,
-      );
-    }
-
-    if (!isString(data.metadata.resourceVersion)) {
-      throw new KubeCreationError(
-        `Cannot create a KubeObject from an object without metadata.resourceVersion being a string`,
-        data,
-      );
-    }
-
     if (!isString(data.metadata.selfLink)) {
       throw new KubeCreationError(
         `Cannot create a KubeObject from an object without metadata.selfLink being a string`,
@@ -136,23 +122,23 @@ export class KubeObject<
     autoBind(this);
   }
 
-  get selfLink() {
+  get selfLink(): string {
     return this.metadata.selfLink;
   }
 
-  getId() {
-    return this.metadata.uid;
+  getId(): string {
+    return this.metadata.uid ?? this.metadata.selfLink;
   }
 
-  getResourceVersion() {
-    return this.metadata.resourceVersion;
+  getResourceVersion(): string {
+    return this.metadata.resourceVersion ?? "";
   }
 
   getScopedName() {
     return [this.getNs(), this.getName()].filter(Boolean).join("/");
   }
 
-  getName() {
+  getName(): string {
     return this.metadata.name;
   }