Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Option for custom date format string (#901) #902

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding Option for custom date format string (#901) #902

wants to merge 3 commits into from

Conversation

jp-9
Copy link

@jp-9 jp-9 commented Dec 22, 2022

No description provided.

@jp-9 jp-9 changed the title Adding Option for custome date format string (#901) Adding Option for custom date format string (#901) Dec 22, 2022
andrewstevenson
andrewstevenson approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@andrewstevenson andrewstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidsloan Lets remember to add to the docs when we do the next release
@jp-9 Thanks

@jp-9
Copy link
Author

jp-9 commented Jan 2, 2023

@andrewstevenson need an approval to re-run CI workflow when you get a chance. Original failed scalafmt checks

@davidsloan
Copy link
Collaborator

Thanks again for the contribution @jp-9 ! Is there any chance you can add some test coverage for the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewstevenson andrewstevenson andrewstevenson approved these changes

Assignees
No one assigned
Labels
needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jp-9 @davidsloan @andrewstevenson @jphillips-grier