Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce MKL interface limits #10

Merged
merged 11 commits into from
Jun 26, 2021

Conversation

mdekstrand
Copy link
Member

This PR checks and enforces limits on the MKL interfaces, and adds data transformations to ensure that it works when possible.

The MKL kernel cannot handle matrices with more than INT_MAX nonzero elements. We now have much better checking, along with utility methods and logic to help with this enforcement and appropriate data transformations.

@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #10 (4b5c0c9) into main (75bb97e) will decrease coverage by 1.28%.
The diff coverage is 80.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   95.51%   94.23%   -1.29%     
==========================================
  Files          19       19              
  Lines         981     1023      +42     
==========================================
+ Hits          937      964      +27     
- Misses         44       59      +15     
Impacted Files Coverage Δ
csr/csr.py 95.14% <77.27%> (-3.56%) ⬇️
csr/kernels/mkl/handle.py 92.47% <78.57%> (-6.18%) ⬇️
csr/_struct.py 82.35% <100.00%> (+3.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75bb97e...4b5c0c9. Read the comment docs.

@mdekstrand mdekstrand merged commit 9dad044 into lenskit:main Jun 26, 2021
@mdekstrand mdekstrand deleted the feature/int64-rowptrs branch June 26, 2021 21:31
@mdekstrand mdekstrand added this to the 0.4.0 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant