Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate CSRs directly for more tests #22

Merged
merged 17 commits into from
Jan 26, 2022

Conversation

mdekstrand
Copy link
Member

This changes test generation to focus on generating CSRs directly in more cases.

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #22 (a8780b8) into main (2e10cd0) will increase coverage by 0.17%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   94.56%   94.74%   +0.17%     
==========================================
  Files          19       19              
  Lines        1085     1103      +18     
==========================================
+ Hits         1026     1045      +19     
+ Misses         59       58       -1     
Impacted Files Coverage Δ
csr/kernels/mkl/handle.py 91.66% <66.66%> (-0.81%) ⬇️
csr/test_utils.py 94.73% <92.30%> (+4.41%) ⬆️
csr/csr.py 95.34% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e10cd0...a8780b8. Read the comment docs.

@mdekstrand mdekstrand merged commit a8780b8 into lenskit:main Jan 26, 2022
@mdekstrand mdekstrand deleted the feature/csr-tests branch January 26, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant