Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scipy='coo' in sparse_ratings #214

Merged
merged 7 commits into from
Dec 31, 2020

Conversation

reppertj
Copy link

Return a scipy.sparse.coo_matrix from sparse_ratings via the argument scipy='coo' (Fixes #213).

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #214 (cfd3e8a) into master (2a3c10f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          43       43           
  Lines        3985     3987    +2     
=======================================
+ Hits         3683     3685    +2     
  Misses        302      302           
Impacted Files Coverage Δ
lenskit/matrix/__init__.py 95.79% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a3c10f...cfd3e8a. Read the comment docs.

@mdekstrand mdekstrand self-assigned this Dec 28, 2020
@mdekstrand
Copy link
Member

Code looks good to me. I'd like to understand why tests failed on Mac with OpenBLAS - triggering a re-build to see if it's ephemeral.

@mdekstrand
Copy link
Member

Upon inspection of the test suite failure, I believe it is unrelated - something perhaps changed in an OpenBLAS update to cause a subtle failure on Mac. I am re-running the master tests to confirm.

If that is the case, we'll be good to merge this change even with those tests failing.

@mdekstrand mdekstrand added this to the 0.12.0 milestone Dec 28, 2020
@mdekstrand mdekstrand added the internals Internal infrastructure (parallelism, math, etc.) label Dec 28, 2020
@mdekstrand mdekstrand merged commit 30179ef into lenskit:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal infrastructure (parallelism, math, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support scipy.sparse.coo_matrix in sparse_ratings
2 participants