Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect user bias transformation #265

Merged
merged 6 commits into from
Jun 17, 2021

Conversation

mdekstrand
Copy link
Member

The root cause of #258 seems to be a bug in the bias transformation, in which item IDs were incorrectly used instead of user IDs to look up user biases.

This closes #258.

@mdekstrand mdekstrand added the bug Something isn't working label Jun 17, 2021
@mdekstrand mdekstrand added this to the 0.13.0 milestone Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #265 (616c5f9) into main (2e7de3a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files          45       45           
  Lines        3761     3761           
=======================================
  Hits         3433     3433           
  Misses        328      328           
Impacted Files Coverage Δ
lenskit/algorithms/als.py 98.06% <100.00%> (ø)
lenskit/algorithms/bias.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7de3a...616c5f9. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Jun 17, 2021

Code Climate has analyzed commit 616c5f9 and detected 0 issues on this pull request.

View more on Code Climate.

@mdekstrand mdekstrand merged commit 8652345 into lenskit:main Jun 17, 2021
@mdekstrand mdekstrand deleted the fix/258-als-bias branch June 17, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model differences between versions
1 participant