Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate c.getBaseDirectory #3266

Closed
3 tasks done
edreamleo opened this issue Apr 9, 2023 · 1 comment
Closed
3 tasks done

Deprecate c.getBaseDirectory #3266

edreamleo opened this issue Apr 9, 2023 · 1 comment
Assignees
@edreamleo
Labels
Code Re Leo's code
Milestone
6.7.3

Comments

@edreamleo
Copy link
Member

edreamleo commented Apr 9, 2023 •
edited
Loading

See PR #3267: g.getBaseDirectory supports strange conventions that are likely seldom used.

This issue is a companion to #3260.

  • Make g.getBaseDirectory a do-nothing.
  • Remove all calls to g.getBaseDirectory in Leo.
  • Remove @string relative-path-base-directory = .
@edreamleo edreamleo added the Code Re Leo's code label Apr 9, 2023
@edreamleo edreamleo added this to the 6.7.3 milestone Apr 9, 2023
@edreamleo edreamleo self-assigned this Apr 9, 2023
@edreamleo edreamleo mentioned this issue Apr 9, 2023
Merged
2 tasks
edreamleo added a commit that referenced this issue Apr 9, 2023
@edreamleo
Merge pull request #3267 from leo-editor/ekr-3266-getBaseDirectory
7449c22 
PR for #3266: simplify path handling further
@edreamleo
Copy link
Member Author

Closed via PR #3267.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edreamleo edreamleo

Labels
Code Re Leo's code
Projects
None yet
Milestone
6.7.3
Development

No branches or pull requests
1 participant
@edreamleo