Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark-first-parents and unmark-first-parents should be undoable like other 'mark' related commands. #3519

Closed
boltex opened this issue Sep 1, 2023 · 1 comment · Fixed by #3520
Closed

mark-first-parents and unmark-first-parents should be undoable like other 'mark' related commands. #3519

boltex opened this issue Sep 1, 2023 · 1 comment · Fixed by #3520
Assignees
@edreamleo @boltex
Labels
Anomaly Bug
Milestone
6.7.5

Comments

@boltex
Copy link
Contributor

boltex commented Sep 1, 2023 •
edited by edreamleo

See PR #3524.

mark-first-parents and it's unmark-first-parents sibling command should allow undo and redo to be performed.

EKR: The legacy names are poor. I'll rename the commands to mark-node-and-parents and unmark-node-and-parents.
@boltex boltex added this to the 6.7.5 milestone Sep 1, 2023
@boltex boltex self-assigned this Sep 1, 2023
boltex added a commit that referenced this issue Sep 1, 2023
@boltex
Made mark-first-parents and unmark-first-parents undoable.
35e6076 
Fixes #3519
@boltex boltex mentioned this issue Sep 1, 2023
Merged
@edreamleo edreamleo self-assigned this Sep 1, 2023
@edreamleo edreamleo mentioned this issue Sep 1, 2023
Merged
3 tasks
@edreamleo
Copy link
Member

Closed via PR #3524.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edreamleo edreamleo

@boltex boltex

Labels
Anomaly Bug
Projects
None yet
Milestone
6.7.5
Development

Successfully merging a pull request may close this issue.

PR: Fix bug in leoUndo.py leo-editor/leo-editor
2 participants
@edreamleo @boltex