Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@clean nodes stopped updating #472

Closed
edreamleo opened this issue Apr 11, 2017 · 2 comments
Closed

@clean nodes stopped updating #472

edreamleo opened this issue Apr 11, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@edreamleo
Copy link
Member

First reported here.

Joe Orr: I'm going back and forth between Leo and Webstorm. (MacOS 10). Until today, when I made a change in a @clean file in Webstorm, Leo would pop up a message saying that the file has been changed and update its copy. That just stopped happening. Now Leo doesn't update the node unless I close and open the Leo file.

I'm not aware of any changes I made in my setup that could have caused this.

After it started happening I did the following:

  1. Deleted my Leo install and reinstalled from git, version is now 5.5.
  2. Verified that Webstorm is updating the file on the filesystem.
  3. Tried deleting and recreating the @clean node.

Refresh from disk works, also, I do get a warning when I try to save changes in Leo version and target file has other changes.

@edreamleo edreamleo self-assigned this Apr 11, 2017
@edreamleo edreamleo added the Bug label Apr 11, 2017
@edreamleo edreamleo added this to the 5.6 milestone Apr 11, 2017
@edreamleo
Copy link
Member Author

edreamleo commented Apr 11, 2017

Updates of both @clean and @file external files work for me on Windows 10.

Naturally, the updates only happen when the external file has been saved to disk.

@edreamleo
Copy link
Member Author

This was a difficult to find problem with settings, a side effect of #262: Improve performance of check_for_changed_external_files.

@bool check_for_changed_external_files must be True to enable checkin in any .leo file.

0fb4cec improves traces in efc.on_idle to make clearer what is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant