Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@bool check_for_changed_external_files may hang on network files #262

Closed
JohnLunzer opened this issue Apr 15, 2016 · 4 comments
Closed

@bool check_for_changed_external_files may hang on network files #262

JohnLunzer opened this issue Apr 15, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@JohnLunzer
Copy link
Contributor

With the current implementation Leo can become unresponsive in some environments. Implementing the checking logic in non-blocking threads or a separate process could mitigate any negative performance impact.

Additionally, if the Leo window is inactive withhold all notifications until Leo becomes active again.

Please see this Leo conversation for reference.

@edreamleo edreamleo modified the milestone: 5.4 Apr 27, 2016
@edreamleo edreamleo removed this from the 5.4 milestone Sep 21, 2016
@edreamleo
Copy link
Member

Rev 4373f88 attempts to fix #262 by checking at most one commander during idle time.

This approach could be extended by checking only one @ node at idle time, but that might result in long delays between checks of an @ node.

Please let me know if the fix works for you.

@edreamleo edreamleo self-assigned this Oct 11, 2016
@edreamleo edreamleo added this to the 5.4 milestone Oct 11, 2016
@edreamleo
Copy link
Member

I am reopening this issue and marking it as a bug because of serious problems when using network drives.

@edreamleo edreamleo reopened this Dec 16, 2016
@edreamleo edreamleo added Bug and removed Enhancement labels Dec 16, 2016
@edreamleo edreamleo modified the milestones: 5.5, 5.4 Dec 16, 2016
@edreamleo edreamleo changed the title Improve performance of check_for_changed_external_files @bool check_for_changed_external_files may hang on network files Dec 16, 2016
edreamleo added a commit that referenced this issue Dec 16, 2016
…ference #262,

@Bool check_for_changed_external_files may hang on network files.

Leo build: 20161216150641
@edreamleo
Copy link
Member

Rev 2a0eca1: set the default setting for @Bool check_for_changed_external_files to False. The comment in the body text of the setting's node references this issue.

Given the potential severity of this bug, I think it's important that people must explicitly enable this feature. It will prevent future reports that Leo has become broken.

@edreamleo
Copy link
Member

It's time to close this issue. I see no reason to leave this issue open indefinitely.

@bool check_for_changed_external_files in leoSettings.leo defaults to False, so it can be said to be safe by default. Furthermore it contains an adequate warning, and references this issue.

@edreamleo edreamleo added this to the 5.4 milestone Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants