Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent Files menu will break for foreign languages #848

Closed
edreamleo opened this issue Apr 4, 2018 · 1 comment
Closed

Recent Files menu will break for foreign languages #848

edreamleo opened this issue Apr 4, 2018 · 1 comment
Assignees
@edreamleo
Labels
Enhancement
Milestone
5.7.2

Comments

@edreamleo
Copy link
Member

edreamleo commented Apr 4, 2018 •
edited

At present the cleaned name must be "Recent Files" to be recognized and populated by rf.createRecentFilesMenuItems.
@edreamleo edreamleo added this to the 5.7.2 milestone Apr 4, 2018
@edreamleo edreamleo self-assigned this Apr 4, 2018
edreamleo added a commit that referenced this issue Apr 10, 2018
@edreamleo
Fixed #848: Recent Files menu will break for foreign languages.
1716585 
Allow the Recent Files menu to have an alternate name. The first non-blank, non-comment line of an @menu node's body is the alternate name.

- Added rf.recentFilesMenuName and related logic.
- Added alt_name logic in several places.
@edreamleo
Copy link
Member Author

edreamleo commented Apr 10, 2018 •
edited

Fixed at 1716585 of the menus branch.

The first non-blank, non-comment line of the node `@menu Recent Files' can contain an alternate (translated) menu name.

You should not just change the headline of the node: it should remain unchanged. Indeed, the point of this item is that Leo has to know which item is the Recent Files item, so some other way was needed to specify an alternate name.

@edreamleo edreamleo removed the EKR label Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edreamleo edreamleo

Labels
Enhancement
Projects
None yet
Milestone
5.7.2
Development

No branches or pull requests
1 participant
@edreamleo