Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for #3375: improve python importer #3376

Merged
merged 15 commits into from Jun 13, 2023
Merged

PR for #3375: improve python importer #3376

merged 15 commits into from Jun 13, 2023

Conversation

edreamleo
Copy link
Member

@edreamleo edreamleo commented Jun 12, 2023 •
edited

See #3375.

  • Scan for ')' before computing leading whitespace.
  • Generate << preamble >> nodes and related section refs for lines appearing before the block.
  • Create Importer.create_preamble and `Python_Importer.create_preamble'.
  • Add allow_prefix and related logic. Change unit tests accordingly.
  • Add unit test.
  • Simplify check_outline and new_run_test.
  • Clean import of all mypy files.
  • Reindent all importer files.

@edreamleo edreamleo added this to the 6.7.4 milestone Jun 12, 2023
@edreamleo edreamleo self-assigned this Jun 12, 2023
@edreamleo edreamleo requested a review from boltex June 12, 2023 18:08
@edreamleo
Copy link
Member Author

@boltex This PR is ready for review.

@edreamleo edreamleo merged commit bdcd099 into devel Jun 13, 2023
@edreamleo edreamleo deleted the ekr-3375-python-importer branch June 13, 2023 07:32
@edreamleo edreamleo mentioned this pull request Jun 13, 2023
Closed
@edreamleo
Copy link
Member Author

@boltex I've merged this PR. The mypy.leo study outline is a strong test of the new code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boltex boltex Awaiting requested review from boltex

Assignees

@edreamleo edreamleo

Labels
Enhancement
Projects
None yet
Milestone
6.7.4
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@edreamleo