Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for #3567: Improve word-oriented finds and Leo's spell checker #3568

Merged
merged 12 commits into from Sep 15, 2023

Conversation

edreamleo
Copy link
Member

@edreamleo edreamleo commented Sep 14, 2023

See #3567. This PR allows improved spell checking of Leo's extended core. See PR #3566.

  • Change SpellTabHandler.find and its related regexes.
    Add several special cases to handle Python syntax.
  • Improve g.match_word so that a word-oriented match will find word in print('\nword').
  • Replace most of find._inner_search_match_word with a call to `g.match_word'.

There are no new unit tests, but several hand-checks pass.

@edreamleo edreamleo added this to the 6.7.5 milestone Sep 14, 2023
@edreamleo edreamleo self-assigned this Sep 14, 2023
@edreamleo
Copy link
Member Author

@boltex I think these changes are worth doing for 6.7.5. What do you think?

@boltex
Copy link
Contributor

boltex commented Sep 15, 2023

Yes lets bring this into 6.7.5 (and I'll also make those changes in leojs right now) Bugfixes are no problem at all 👍

Copy link
Contributor

@boltex boltex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- I've done the same in leojs

@edreamleo edreamleo marked this pull request as draft September 15, 2023 05:45
@edreamleo
Copy link
Member Author

edreamleo commented Sep 15, 2023

@boltex Thanks for your comment. I'm still working on the spelling-related part of this PR.

@edreamleo edreamleo mentioned this pull request Sep 15, 2023
@edreamleo edreamleo marked this pull request as ready for review September 15, 2023 12:18
@edreamleo edreamleo merged commit d3d159d into devel Sep 15, 2023
@edreamleo edreamleo deleted the ekr-3567-word-boundaries branch September 15, 2023 12:43
@edreamleo edreamleo changed the title PR for #3567: word boundaries PR for #3567: Improve word-oriented finds and Leo's spell checker Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants