fix(latest): config (valor-software#4716)

* fix(latest): config * feat(latest): add tsickle to config * feat(schematics): clean up
leo6104 · Oct 10, 2019 · 4fc3af3 · 4fc3af3
1 parent 2bda1ec
commit 4fc3af3
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 61 deletions.
diff --git a/.gitignore b/.gitignore
@@ -42,3 +42,7 @@ src/**/*.js
 src/**/*.map
 scripts/**/*.js
 scripts/**/*.map
+
+schematics/src/**/*.js
+schematics/src/**/*.js.map
+schematics/src/**/*.d.ts
diff --git a/package.json b/package.json
@@ -30,7 +30,8 @@
     "build.es2015": "node ./scripts/es2015/bundle.es2015.js",
     "start": "ng serve --aot --host 0.0.0.0",
     "pretest": "run-s lint build",
-    "test": "ng test",
+    "test": "ng test && npm run test:schematics",
+    "test:schematics": "jasmine schematics/src/**/*.spec.js",
     "test-cross": "SAUCE=true ng test",
     "test-coverage": "ng test --code-coverage",
     "version": "node scripts/version && npm run version.changelog",
@@ -153,7 +154,7 @@
     "tslint": "5.10.0",
     "tslint-config-valorsoft": "2.1.1",
     "typedoc": "0.11.1",
-    "typescript": "~2.7.2",
+    "typescript": "2.7.2",
     "wait-on": "2.1.0",
     "wallaby-webpack": "3.9.7",
     "webpack-bundle-analyzer": "2.11.3",

diff --git a/schematics/.gitignore b/schematics/.gitignore
diff --git a/schematics/.npmignore b/schematics/.npmignore
diff --git a/schematics/README.md b/schematics/README.md
diff --git a/schematics/package.json b/schematics/package.json
diff --git a/scripts/ci/npm-ng-latest.sh b/scripts/ci/npm-ng-latest.sh
@@ -14,4 +14,7 @@ npm i @angular/animations@latest \
     @angular/platform-browser-dynamic@latest \
     @angular/router@latest \
     @angular/service-worker@latest \
-    rxjs@6.0.0
+    @schematics/angular@latest \
+    typescript@3.1.1 \
+    tsickle@0.33.0 \
+    rxjs@6.3
diff --git a/src/chronos/utils/type-checks.ts b/src/chronos/utils/type-checks.ts
@@ -34,7 +34,9 @@ export function isArray<T>(input?: any): input is T[] {
   );
 }
 
-export function hasOwnProp<T>(a: T /*object*/, b: string): b is keyof T {
+// TODO: returned type should be changed to "b is Extract<keyof T, string>"
+// after update to typescript 3.1.1 (issue 4728)
+export function hasOwnProp<T>(a: T /*object*/, b: string): boolean {
   return Object.prototype.hasOwnProperty.call(a, b);
 }
 

diff --git a/src/tsconfig.json b/src/tsconfig.json
@@ -11,6 +11,7 @@
     "inlineSources": true,
     "noEmitHelpers": false,
     "noImplicitAny": true,
+    "suppressImplicitAnyIndexErrors": true,
     "declaration": true,
     "skipLibCheck": false,
     "stripInternal": true,