Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(latest): config #4716

Merged
merged 4 commits into from Oct 23, 2018
Merged

fix(latest): config #4716

merged 4 commits into from Oct 23, 2018

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Oct 19, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned Domainv Oct 19, 2018
@ghost ghost added the needs review label Oct 19, 2018
@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #4716 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4716   +/-   ##
============================================
  Coverage        74.34%   74.34%           
============================================
  Files              202      202           
  Lines             7102     7102           
  Branches          1447     1447           
============================================
  Hits              5280     5280           
  Misses            1425     1425           
  Partials           397      397
Impacted Files Coverage Δ
src/chronos/utils/type-checks.ts 91.89% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb907a9...1be1a51. Read the comment docs.

@Domainv Domainv force-pushed the fix-latest branch 3 times, most recently from f176ffe to 1613655 Compare October 23, 2018 08:55
valorkin
valorkin previously approved these changes Oct 23, 2018
@valorkin valorkin merged commit 89e967f into development Oct 23, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-latest branch October 23, 2018 16:01
@ghost ghost removed the needs review label Oct 23, 2018
svetoldo4444ka pushed a commit to svetoldo4444ka/ngx-bootstrap that referenced this pull request Nov 6, 2018
* fix(latest): config

* feat(latest): add tsickle to config

* feat(schematics): clean up
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
* fix(latest): config

* feat(latest): add tsickle to config

* feat(schematics): clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants