Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-104599 Reorganizing the upgrade processes to be able to backport it to 7.2.x #642

Closed
wants to merge 2 commits into from

Conversation

achaparro
Copy link

@achaparro achaparro commented Dec 18, 2019

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@achaparro
Copy link
Author

ci:test:sf

@achaparro
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 38 seconds 7 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 32fd4b9ebc7837e70d1540f557a674c21d1c8a01

Sender Branch:

Branch Name: pr-400
Branch GIT ID: d4a682c1f719a4580a1b9d8418e907e0e4186206

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 0 out of 1 jobs passed in 2 hours 11 minutes 11 seconds 686 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cfe18fba34991d93b8b84206ae02bdad21e82c6f

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6c0b5322d1e18eac4342d74f6522c7b7a9bbd7ed

ci:test:relevant - 0 out of 1 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    0 Jobs Passed.
    1 Job Failed.

    A CI failure has occurred. QA Engineering has been notified. Please try again later or contact QA Engineering for an update.

For upstream results, click here.

@achaparro
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 8 out of 8 jobs passed

❌ ci:test:relevant - 27 out of 29 jobs passed in 1 hour 14 minutes 49 seconds 351 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cfe18fba34991d93b8b84206ae02bdad21e82c6f

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6c0b5322d1e18eac4342d74f6522c7b7a9bbd7ed

ci:test:stable - 8 out of 8 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 27 out of 29 jobs PASSED
27 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8
    Job Results:

    762 Tests Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #345942
      1. treeview.Treeview allows selecting several nodes by default
        Error: expect(received).toBe(expected) // Object.is equality
        

        Expected: true
        Received: false
        at Object.toBe (frontend-js/frontend-js-components-web/test/treeview/Treeview.js:152:44)
        at Object.asyncJestTest (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
        at resolve (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
        at new Promise (<anonymous>)
        at mapper (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
        at promise.then (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
        at process._tickCallback (internal/process/next_tick.js:68:7)

      2. treeview.Treeview allows selecting only one node if multiSelection is disabled
        Error: expect(received).toBe(expected) // Object.is equality

        Expected: true
        Received: false
        at Object.toBe (frontend-js/frontend-js-components-web/test/treeview/Treeview.js:165:44)
        at Object.asyncJestTest (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
        at resolve (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
        at new Promise (<anonymous>)
        at mapper (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
        at promise.then (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
        at process._tickCallback (internal/process/next_tick.js:68:7)

      3. treeview.Treeview allows specifying a custom NodeComponent
        Error: expect(received).toBe(expected) // Object.is equality

        Expected: "true"
        Received: "false"
        at Object.toBe (frontend-js/frontend-js-components-web/test/treeview/Treeview.js:229:35)
        at Object.asyncJestTest (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
        at resolve (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
        at new Promise (<anonymous>)
        at mapper (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
        at promise.then (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
        at process._tickCallback (internal/process/next_tick.js:68:7)

For upstream results, click here.

@leoadb
Copy link
Owner

leoadb commented Jan 6, 2020

Just started reviewing :)

@leoadb
Copy link
Owner

leoadb commented Jan 6, 2020

sent to brianchandotcom#82812

@leoadb leoadb closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants