Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a custom FLUTTER_STORAGE_BASE_URL as the source for Flutter package downloads #688

Open
oravecz opened this issue Mar 9, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@oravecz
Copy link

oravecz commented Mar 9, 2024

We cannot install Flutter from a Git cache, nor can we download Flutter from the https://storage.googleapis.com/flutter_infra_release/releases location. Instead, we maintain our own versions of Flutter SDKs on an internal location which we set our FLUTTER_STORAGE_BASE_URL to. We also maintain our own version of the Flutter metadata files with our own checksum values in the same manner as Google.

Looking at the source code, I thought that FVM would respect the FLUTTER_STORAGE_BASE_URL environment variable, but it does not.

Is it feasible to make a modification to the source code to ensure that FLUTTER_STORAGE_BASE_URL is used as the source for Flutter packages to be put in the local cache?

Originally posted by @oravecz in #571

@leoafarias leoafarias added the enhancement New feature or request label Mar 19, 2024
@digoreis
Copy link
Contributor

@oravecz this issue was resolved in this PR #593 , correct ?

@charles0122
Copy link

@digoreis I think this is another solution, the method of setting FLUTTER_STORAGE_BASE_URL and FLUTTER_GIT_URL two variables is different, the former is generally strong, but requires fvm to adjust more code, the latter is more relevant, the modification is only download flutter specific sdk's repository

@oravecz
Copy link
Author

oravecz commented Sep 11, 2024

Setting FLUTTER_GIT_URL was the approach we needed to be able to point fvm at our custom Flutter git repository.

If I recall correctly, this ticket was made earlier before I understood the difference between the two environment variables.

@charles0122
Copy link

If that's the case, and you found that the solution to this problem was to set FLUTTER_GIT_URL, then you can change the environment variable in the title and close this issue. If you still have other problems, you can open another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants