Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple guide to build project in readme.md #25

Merged
merged 1 commit into from Sep 19, 2014

Conversation

raphamorim
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d6f88d8 on raphamorim:master into e288762 on leobalter:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a221d99 on raphamorim:master into e288762 on leobalter:master.

@@ -40,6 +40,16 @@ Dexter is supported and tested on:

The project documentation files are located in https://github.com/leobalter/DexterJS/tree/master/docs

## Build

Install Grunt and external dependencies. First, install the grunt-cli if you haven't before. This should be installed globally (like this: `npm install -g grunt-cli bower`). Then:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's omit bower here.

@leobalter
Copy link
Owner

Would be better if we include two things:

  • A reference link on the getting started section (a new bullet item mentioning to build your own copy).
  • A intro part mentioning to clone this repo.

leobalter added a commit that referenced this pull request Sep 19, 2014
add simple guide to build project in readme.md
@leobalter leobalter merged commit ec622fc into leobalter:master Sep 19, 2014
@raphamorim
Copy link
Contributor Author

Gotcha @leobalter, i've got a question: Did you consider build and run tests using Docker?

If yes, can I send a PR w/ this improvement?

@leobalter
Copy link
Owner

I've done the suggestions on Readme. :)

What is docker? (searching on duckduckgo...)

@raphamorim
Copy link
Contributor Author

With a docker file, you can run the project over a image from defined system. This eliminates problems with workspace and other things.

Check out: https://www.docker.com/whatisdocker/

@leobalter
Copy link
Owner

It doesn't look necessary at this point. Sometimes I just avoid things that could increase complexity without much value return. If you insist, I can try it, but at this moment my targets are the xhr2 and timer issues.

@raphamorim
Copy link
Contributor Author

I understand. So i'll focus in xhr2 and timer issues :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants