Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove horizontal lines that are distracting at normal zoom levels #52

Closed
mikef80 opened this issue Nov 15, 2021 · 22 comments
Closed

Remove horizontal lines that are distracting at normal zoom levels #52

mikef80 opened this issue Nov 15, 2021 · 22 comments

Comments

@mikef80
Copy link

mikef80 commented Nov 15, 2021 •
edited

Hi. Firstly, let me say that this is a great extension! I heard about it when you posted it on Codecademy and have shared with so many people!

When at normal zoom levels, I have an awful lot of horizontal lines generated by Blockman, as shown in the first screen shot:

image

However, when I zoom out a bit, these disappear, leaving behind just the borders of the blocks. I can't find an option to make this the default choice for me - is it possible?

image

Thank you!
@Ollie-Boyd
Copy link

Ollie-Boyd commented Nov 15, 2021 •
edited

I just came to ask about the same issue

@leodevbro
Copy link
Owner

I think it is a VSCode limitation, not a bug of Blockman.
the editor font zoom is not exposed in any way to the API, so, it means Blockman cannot detect font zoom level, because VSCode API simply does not give us access to it.

microsoft/vscode#125341 (comment)

@leodevbro
Copy link
Owner

Also, I want to ask you, which type of zoom are you mentioning? mouse wheel zoom? or Window: Zoom Level ?

@Ollie-Boyd
Copy link

@leodevbro mine shows these horizontal lines on a fresh install of VS Code at default zoom level. If I ctrl+'-' to zoom out the lines reduce but they are still there. When I scroll the lines jump about

@Ollie-Boyd
Copy link

Default zoom
image
Zoomed out
image

@mikef80
Copy link
Author

mikef80 commented Nov 16, 2021

Mine also shows on default zoom levels. What I have noticed though is that it's only happening on my home PC (4K monitors set to 150% scale). Mine behave much as @Ollie-Boyd describes above. However, my work monitors (Full HD at 100% scale) don't show these horizontal lines, no matter how much I zoom in or out. Both systems are using fresh installs and I have tried it with all other add-ons disabled to check for any adverse interaction.

@abhi-k9
Copy link

abhi-k9 commented Nov 19, 2021

Can confirm this issue on default zoom.

Lines appear and disappear on scrolling. There doesn't seem to a specific patter as far as I can tell.

@leodevbro
Copy link
Owner

leodevbro commented Nov 19, 2021 •
edited

Has anyone here experienced this issue on a monitor with less than 4K resolution?

@abhi-k9
Copy link

abhi-k9 commented Nov 19, 2021

That would be me.

@mikef80
Copy link
Author

mikef80 commented Nov 19, 2021

That would be me.

What resolution are you using and are you scaling at all?

@leodevbro
Copy link
Owner

image

Well, now I tested on my 1920x1080 monitor with playing around the Windows scaling settings. Turns out the block rendering of Blockman extension goes crazy (like in your screenshots) on every percentage setting other than 100%. So, I think the problem is in Windows 10 scaling algorithm or in VSCode scaling algorithm or both. So, I guess Blockman itself is not responsible for this issue at all.

So, maybe we should make a bug report in VSCode repo in Github.

@abhi-k9
Copy link

abhi-k9 commented Nov 20, 2021 •
edited

System display settings:

  • Scale: 125% (Recommended)
  • Resolution: 1920 x 1200 (Recommended)

VSCode settings:

  • Editor Font Size: 18

System:

  • Windows 11

As @leodevbro pointed out, issue seems to disappear on 100% scaling.

Does this happen on other systems too? (Mac, Linux?)

@Ollie-Boyd
Copy link

Ollie-Boyd commented Nov 20, 2021 via email

@mikef80
Copy link
Author

mikef80 commented Nov 20, 2021 via email

@leodevbro
Copy link
Owner

I made a bug report just now in the vscode repo:
microsoft/vscode#137609

Please like it, so it gets better chance to be fixed.

@leodevbro
Copy link
Owner

Very good news: I fixed the mouse wheel zoom behavior of Blockman. The latest version of Blockman is 1.4.5 (2022-01-03).

I know your issue is not about mouse wheel zoom, it's about Window: Zoom Level (Ctrl and + / -), but I think the fix of mouse wheel zooming will greatly help the Window: Zoom Level zooming to have much less artifacts (horizontal lines). Please check it out.

@leodevbro leodevbro mentioned this issue Mar 13, 2022
Open
@mathric
Copy link

mathric commented Mar 31, 2022

Just got into the same problem. Have solved it temporarily using try and error way by adjust the Mouse Wheel Scroll Sensitivity and zoom level in vscode setting. Hope this can help someone before the bug report being addressed.

@leodevbro
Copy link
Owner

@mikef80, @abhi-k9, @rgehrsitz, @Ollie-Boyd, @mathric,
Hi everyone, I want to ask you to update VSCode to the latest version (1.66) and check the issue again. For me, I discovered that somehow this issue (strange horizontal lines) is no longer reproducible in my machine. It seems pretty much fixed. Well, I tried many different ugly zooming settings and the worst scenario I got is one or two rare horizontal lines, so in most cases it seems fixed. So, please check it again and tell me if the situation is changed or not.

@mikef80
Copy link
Author

mikef80 commented Apr 1, 2022

Hi @leodevbro,

You're right! I've just updated to 1.66 on my Mac and it looks like the issue is gone. Perfect! Haven't checked on my own PC yet, but my work PC appears to also be fixed! Great work!

@rgehrsitz
Copy link

It's working on my 4K Windows display using using VSCode 1.66. Now I can appreciate what this extension is really supposed to look like. Excellent!

@mikef80
Copy link
Author

mikef80 commented Apr 1, 2022

Yeah, mine's a 4K too - looks bloody great!

@mathric
Copy link

mathric commented Apr 1, 2022

Yes, it also works on my laptop which is not support 4K

@leodevbro leodevbro mentioned this issue Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mikef80 @mathric @rgehrsitz @Ollie-Boyd @abhi-k9 @leodevbro