Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support many RFC3164 old formats (OpenBSD, IQTS-IP200, Synology NAS, Unifi UAP and UGP) #13

Merged
merged 11 commits into from
May 20, 2024

Conversation

leodido
Copy link
Owner

@leodido leodido commented May 20, 2024

Rebase/revamp from #2

Here a PR with goal to support many different old syslog.

This changes allows to support:

OpenBSD syslog
IP socket IQTS-IP200
Synology NAS
Unifi UAP and UGP
Probably many other edge cases and hardware.

Thus, it includes: influxdata/go-syslog#46, influxdata/go-syslog#49 and influxdata/go-syslog#54

Thanks to @catap and all the authors @aparcar @z3bra @tosuke 👏

z3bra and others added 11 commits May 20, 2024 18:04
OpenBSD like many other hardware sends syslog messages without hostname,
here I added support of such messages.

Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
Some old syslog may add LF between two messages, outside of counters.
It is qutie confusing when it parses a message but returns error as
well, that it was mallforemd.

So, I've used the best effort flag as the way to decide. When it true,
it gnores all errors, but when it false it ignores the message.
both nontransparent and octetcounting use RFC5424 which isn't used by
many devices, i.e. OpenWrt or Ubiquiti routers.

Add a new function called NewParserRFC3164 to both.

Signed-off-by: Paul Spooren <mail@aparcar.org>
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
Unifi thinks that it can be up to 48 characters, tolerate it.

Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido leodido self-assigned this May 20, 2024
@leodido leodido changed the title feat: RFC3164 OpenBSD feat: support many RFC3164 old formats (OpenBSD, IQTS-IP200, Synology NAS, Unifi UAP and UGP) May 20, 2024
@leodido leodido added the enhancement New feature or request label May 20, 2024
@leodido leodido mentioned this pull request May 20, 2024
@leodido leodido merged commit bfd8811 into develop May 20, 2024
5 checks passed
@leodido leodido deleted the rfc3164-openbsd branch May 20, 2024 16:54
@aparcar
Copy link
Contributor

aparcar commented May 20, 2024

Amazing thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants