Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: usage of ESM modules imports (instead of CommonJS) #182

Merged
merged 5 commits into from
Mar 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"extends": ["conventions", "prettier"],
"plugins": ["prettier", "import"],
"plugins": ["prettier", "import", "unicorn"],
"parserOptions": {
"project": "./tsconfig.json"
},
"env": {
"node": true,
"jest": true
"node": true
},
"rules": {
"prettier/prettier": "error",
"import/extensions": ["error", "always"]
"import/extensions": ["error", "always"],
"unicorn/prefer-node-protocol": "error"
}
}
3 changes: 3 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ jobs:
- name: 'Install'
run: 'npm install'

- name: 'Build'
run: 'npm run build'

- name: 'Unit Test'
run: 'npm run test:unit'

Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ build

# testing
coverage
.nyc_output

# debug
npm-debug.log*
Expand Down
2 changes: 1 addition & 1 deletion .swcrc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"loose": true
},
"module": {
"type": "commonjs",
"type": "es6",
"strict": false,
"strictMode": true,
"lazy": false,
Expand Down
9 changes: 9 additions & 0 deletions .taprc
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
ts: false
jsx: false
flow: false
check-coverage: false
coverage: false
timeout: 1200000

files:
- 'build/**/*.test.js'
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ leon

- **Please first discuss** the change you wish to make via [issue](https://github.com/leon-ai/leon-cli/issues) before making a change. It might avoid a waste of your time.

- Ensure your code respect `eslint` and `prettier`.
- Ensure your code respect linting.

- Make sure your **code passes the tests**.

Expand Down
9 changes: 0 additions & 9 deletions jest.config.json

This file was deleted.

10 changes: 0 additions & 10 deletions jest.e2e.config.json

This file was deleted.

Loading