Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max-width for TODO #53

Closed
wants to merge 1 commit into from
Closed

Increase max-width for TODO #53

wants to merge 1 commit into from

Conversation

w3bdesign
Copy link
Contributor

@w3bdesign w3bdesign commented Jun 18, 2020

fix: Fixed width for TODO listings on desktop view.

Increase max-width for TODO Item to 100% for desktop
@leonardopliski
Copy link
Owner

Hey @w3bdesign!

Thanks for your contribution! May you update the commit to the conventional commits convention?

@w3bdesign
Copy link
Contributor Author

w3bdesign commented Jun 19, 2020

Hey @w3bdesign!

Thanks for your contribution! May you update the commit to the conventional commits convention?

Sorry, I haven't heard of conventionalcommits before.

Is the following ok?

feat: Modified width for TODO listings on desktop view, as it did not look good on desktop.

@leonardopliski
Copy link
Owner

It's almost there,

Things to be improved:

  1. The first line of your commit message must have a maximum of 50 characters long. No more, and (ideally), no less. See 50/72 rule.
  2. It's not a feat type commit, this change is related to the style context, and isn't a new feature. See @commitlint/config-conventional.
  3. It's recommended to break your commits on multiple lines. See How can I make git commit messages divide into multiple lines

So the desired message should look like:

style(todo-listings): increased width on desktop

* It didn't look good on desktop screens.

@w3bdesign
Copy link
Contributor Author

I deleted the old repository for this, so I can't amend the changes.

I created a new PR for it instead.

@w3bdesign w3bdesign closed this Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants