Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only create max_bits once at the top level #111

Merged
merged 1 commit into from
May 30, 2019
Merged

only create max_bits once at the top level #111

merged 1 commit into from
May 30, 2019

Conversation

hofstee
Copy link
Collaborator

@hofstee hofstee commented May 28, 2019

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 987

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.293%

Totals Coverage Status
Change from base Build 966: 0.0%
Covered Lines: 1387
Relevant Lines: 1818

💛 - Coveralls

@hofstee hofstee requested a review from leonardt May 29, 2019 04:03
Copy link
Owner

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like this code path (performance issue with calling platform.architecture()) was avoided on master, but maybe it's still in your branch which was created before the change? Regardless, this change is okay

@leonardt leonardt merged commit 94ce986 into master May 30, 2019
@leonardt leonardt deleted the maxbits branch May 30, 2019 02:14
@hofstee
Copy link
Collaborator Author

hofstee commented May 30, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants