Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get inputs from signature instead of decorator #12

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Conversation

hofstee
Copy link
Collaborator

@hofstee hofstee commented Oct 15, 2018

No description provided.

@hofstee
Copy link
Collaborator Author

hofstee commented Oct 16, 2018

All of the changes are really in coroutine.py. I tried to adopt the same style of using type hints like magma, but it ended up with a bunch of function calls expecting those arguments to be passed into the coroutine when constructing the circuit so I captured them in the coroutine decorator and instantiate the function with arguments.

@leonardt you might know a better way to go about handling this?

@hofstee hofstee merged commit b6fa799 into master Oct 16, 2018
@hofstee hofstee deleted the fun-sig-master branch October 16, 2018 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants