Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: a new option "exactInput" - allowing the value to be set between steps #1094

Merged
merged 6 commits into from
Sep 16, 2020

Conversation

tenglongroy
Copy link
Contributor

issue #436, inspired by @janein , hoping to allow the value to be able to set between steps. The value in tooltip also reflects the actual value.

@leongersen
Copy link
Owner

Hi @tenglongroy, thanks for contributing. I think there is value in this feature, but it might be better implemented as an optional argument to the set method. When exactInput exists as an slider-wide setting, it isn't possible to selectively override this behavior from the outside. For example, it might be desirable to have the value from a text input be exactly represented on the slider, but to have other API interactions be matched to the slider's steps.

Additionally, for me to a PR, it will need to add tests for the new feature.

…tting to optional argument in set( ) and setHandle( ). Also added tests for this feature.
@tenglongroy
Copy link
Contributor Author

Hi @leongersen , thanks for your comment, just made a commit with the changes you suggested:

  • change 'exactInput' from slider-wide setting to optional argument in set( ) and setHandle( )
  • added tests for this feature.

@leongersen leongersen merged commit 48eca11 into leongersen:master Sep 16, 2020
@leongersen
Copy link
Owner

@tenglongroy Thanks for this PR. I just merged it and released noUiSlider 14.6.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants