Multitouch Support #793
Multitouch Support #793
Conversation
…dlesCount. This fix allows the drag class to be properly removed when a drag stops, even if disabled handles are the target of touches.
|
Many thanks for this pull request! I'm currently abroad with no access to a development machine, but I'll try to find to find a way to get this tested and merged. Stylistically, I'm happy with the changes you've made. Moving the feature behind a flag is a good idea, it'll make it easier to merge with confidence. |
|
Any news on this? |
|
Sorry, like I mentioned, I don't have access to a development machine (and won't for any time soon). Given the quality of this pull request, I'd be willing to give you push access to the repository, if you're ok with that. |
|
Oh, OK I understand. |
|
Yes, we're talking the release process. It's pretty simple: I update the
readme.md, run the release job with grunt, create a release on GitHub with
the generated zip and run npm publish. Are you up for that?
…On Jul 19, 2017 9:48 PM, "Quentin Roy" ***@***.***> wrote:
Oh, OK I understand.
Sure I have no issues with this.
Though if it is not about testing the PR yourself and if you are ready to
trust me on this, I do not fully understand what prevents you from just
clicking on "merge" yourself (it should be automatically merge-able by
GitHub, isn't it?). Is it about creating a new release?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#793 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABJoWWBeXNk-Kbagqsffn5T6tK7tNZQlks5sPr_lgaJpZM4N4Etv>
.
|
|
OK. I can do the release.
… On Jul 21, 2017, at 04:10, Leon Gersen ***@***.***> wrote:
Yes, we're talking the release process. It's pretty simple: I update the
readme.md, run the release job with grunt, create a release on GitHub with
the generated zip and run npm publish. Are you up for that?
On Jul 19, 2017 9:48 PM, "Quentin Roy" ***@***.***> wrote:
> Oh, OK I understand.
> Sure I have no issues with this.
> Though if it is not about testing the PR yourself and if you are ready to
> trust me on this, I do not fully understand what prevents you from just
> clicking on "merge" yourself (it should be automatically merge-able by
> GitHub, isn't it?). Is it about creating a new release?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#793 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABJoWWBeXNk-Kbagqsffn5T6tK7tNZQlks5sPr_lgaJpZM4N4Etv>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#793 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAse4WRXQlTHa5J1d6GaCulbGyOWuuDRks5sP8JBgaJpZM4N4Etv>.
|
|
I've added you as a collaborator to GitHub and NPM. Thanks! |
|
It seems I still don't have the write access. I cannot create a new release and I do not see the "Merge" button (I did not try to push directly to "master" with |
|
You should have received an email by GitHub asking you to accept an invite.
GitHub still shows your status as pending.
…On Jul 26, 2017 03:36, "Quentin Roy" ***@***.***> wrote:
It seems I still don't have the write access. I cannot create a new
release and I do not see the "Merge" button (I did not try to push directly
to "master" with git).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#793 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABJoWQK-PmRlaVVFQ0FPNDPExh6IPHQGks5sRwi4gaJpZM4N4Etv>
.
|
|
Right. I missed this one. Thanks. |
Introduce the multitouch option (disabled by default so minor-release friendly).
When enabled, the option allows a handle to be simultaneously manipulated with other content on the page. For example, it makes it possible to manipulate a slider while having another finger down on a target, to manipulate 2 sliders in parallel, or even to manipulate several handles of the same slider.