Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launch_xvfb - display and dimensions should be instance variables #38

Closed
wants to merge 1 commit into from
Closed

Conversation

ShockwaveNN
Copy link
Contributor

No description provided.

@leonid-shevtsov
Copy link
Owner

I'm actually consciously using the public interface to access those instance variables there.

@ShockwaveNN
Copy link
Contributor Author

If so - you probably should change func
def attach_xvfb
possible_display_set = @autopick_display ? @display..MAX_DISPLAY_NUMBER : Array(@display)
pick_available_display(possible_display_set, @reuse_display)
end
to use interface instead of @display

@abotalov
Copy link
Contributor

abotalov commented Jul 8, 2014

I think it can be closed as it's refactored in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants